Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some questions #6

Closed
fst813 opened this issue Aug 11, 2020 · 1 comment
Closed

Some questions #6

fst813 opened this issue Aug 11, 2020 · 1 comment
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@fst813
Copy link

fst813 commented Aug 11, 2020

hello!
In the soft_matcher.py file, the index on line 140 should be the position of the trigger. If you convert the position information to Word (using IDx2Word [index]), this seems to be an error.What does trigger_list stand for?

@danny911kr danny911kr self-assigned this Aug 17, 2020
@yuchenlin yuchenlin added the documentation Improvements or additions to documentation label Sep 5, 2020
@danny911kr
Copy link
Collaborator

Hi @fst813

Sorry for the late reply.
This is not an error. trigger_list stands for the string name of the trigger. (logits_list stands for trigger vectors, predicted_list stands for types of the trigger vectors)

The reason why we use the trigger_list is to find the type duplication of the same trigger.
If you look at line 101 at semi_supervised.py, you can check the function remove_duplicates.
We are trying to polish the triggers by deleting triggers that have more than one entity type and pooling the multiple trigger vectors of the same trigger.

We will improve the comments around this line.
Thank you for your comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

3 participants