Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vimeo support #9

Closed
craftzdog opened this issue Mar 8, 2023 · 7 comments
Closed

Vimeo support #9

craftzdog opened this issue Mar 8, 2023 · 7 comments

Comments

@craftzdog
Copy link
Contributor

https://forum.inkdrop.app/t/embed-a-vimeo-external-content-to-note/3820

@0NotApplicable0
Copy link
Contributor

@craftzdog see #10

@craftzdog
Copy link
Contributor Author

Can you fix the wrong aspect ratio that happens in the side-by-side mode?

Screenshot 2023-03-20 at 09 31 50

I think this solution would work:

https://stackoverflow.com/a/50014014

@0NotApplicable0
Copy link
Contributor

Sure thing

@0NotApplicable0
Copy link
Contributor

0NotApplicable0 commented Mar 20, 2023

This is a screenshot with those suggested StackOverflow changes in full screen which makes the video keep growing to match the size of the container and ignores the 344px height restriction.
CleanShot 2023-03-20 at 18 33 07@2x

Vimeo does provide a URL param of "transparent" setting this to 0 will lock the player and then have the inner video match aspect ratios as such. This doesn't require any style changes and is just an addition to the URL.
CleanShot 2023-03-20 at 18 41 29@2x

I think that we want the 2nd one right?

@craftzdog
Copy link
Contributor Author

Yeah, the second one looks better.
Ideally, the width and height of the video iframes should both be restricted while preserving the aspect ratio and be centered.
If it looks hard, let's take the second approach for now!

@0NotApplicable0
Copy link
Contributor

@craftzdog see #11

Sorry for the delay, had some things get in the way. This just takes the second approach, if I get more time in the future I can look at completely mimicking the Youtube provider styles.

@craftzdog
Copy link
Contributor Author

craftzdog commented Apr 4, 2023

Landed in v0.2.0! Thank you so much for contributing, @0NotApplicable0 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants