Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correction on Golang+Protobuf comment #92

Closed
phillip-elm opened this issue Oct 3, 2022 · 1 comment · Fixed by #93
Closed

Correction on Golang+Protobuf comment #92

phillip-elm opened this issue Oct 3, 2022 · 1 comment · Fixed by #93

Comments

@phillip-elm
Copy link

This library looks pretty cool! That said, there's an incorrect statement in the README:

That is something that Google Protobuf doesn't have, and malformed content will cause panic.

This is untrue. proto.Unmarshal returns an error when the data received isn't valid. gRPC would never be taken seriously if it fell over when a bad message is received...
@inkeliz
Copy link
Owner

inkeliz commented Oct 3, 2022

I think I confuse Google Protobuf and Google Flatbuffers, since the names are similar and all benchmarks are comparing against Flatbuffers. In that case, Flatbuffers doesnt have any validation: google/flatbuffers#5367.

I'll fix that message soon.

@inkeliz inkeliz mentioned this issue Oct 3, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

readme: change Protobuf/Flatbuffers inkeliz/karmem
2 participants
@phillip-elm @inkeliz