Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select not updating selected value after filters are changed #69

Closed
1 of 2 tasks
cassmbautista opened this issue Aug 20, 2019 · 6 comments
Closed
1 of 2 tasks

Select not updating selected value after filters are changed #69

cassmbautista opened this issue Aug 20, 2019 · 6 comments
Assignees
Labels
confirmed Issues that have been confirmed through a reduced test case. js Issues stemming from our compiled or source JavaScript files.

Comments

@cassmbautista
Copy link

cassmbautista commented Aug 20, 2019

  • I'm submitting a:

    • Bug Report
    • Feature Request
  • What is the current behavior?
    When changing the filters for the i-select-option during runtime, this error is produced:
    image
    The current behavior of the select is that the value selected is not correct. See this JS fiddle for the difference between normal select and i-select.
    https://jsfiddle.net/816d9skh/

  • What is the expected behavior? (If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem** viahttps://plnkr.co or similar.)
    The select should be able to update based on filters that are dynamic (computed filters as well).

  • Please tell us about your environment:

    • Version: CDN
    • Browser: Chrome 74.0.3729.169 | Mobile Chrome XX
    • Language: ES6/7
  • Other information (Detailed explanation, stacktraces, related issues, suggestions how to fix, links for us to have context, eg. stackoverflow, gitter, etc.)

@alexgrozav
Copy link
Member

Hi, there seems to be a typo in your code. The default select is using slectedFilter, while the Inkline one is using selectedFilter. Is that, perhaps the issue that you're facing?

@cassmbautista
Copy link
Author

There was a typo here is the updated js fiddle:

The issue is still occurring.

@alexgrozav alexgrozav added confirmed Issues that have been confirmed through a reduced test case. js Issues stemming from our compiled or source JavaScript files. labels Aug 22, 2019
@alexgrozav alexgrozav self-assigned this Aug 23, 2019
@alexgrozav
Copy link
Member

Thanks for the update! I'm working on it.

@cassmbautista
Copy link
Author

While the fix works on a laptop this does not fix the issue on mobile, since the options are not being reset when the slots are updated. I have a branch open to fix this issue, however, I am stuck trying to figure out how to change the slots in the middle of a test, that kind of goes against vue-test-utils. See https://github.com/cassmbautista/inkline/tree/issue69-bugfix-async-select-update

@alexgrozav
Copy link
Member

Ok, good point. I'm looking into it as well.

@alexgrozav alexgrozav reopened this Aug 25, 2019
@alexgrozav
Copy link
Member

Hey! The bug should be fixed in @inkline/inkline@1.16.5. Can you confirm that it's working for your use case as well?

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
confirmed Issues that have been confirmed through a reduced test case. js Issues stemming from our compiled or source JavaScript files.
Projects
None yet
Development

No branches or pull requests

2 participants