Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move std::fs::file.remove to std::fs::path::Path.remove #586

Closed
yorickpeterse opened this issue Jul 5, 2023 · 0 comments
Closed

Move std::fs::file.remove to std::fs::path::Path.remove #586

yorickpeterse opened this issue Jul 5, 2023 · 0 comments
Labels
accepting contributions Issues that are suitable to be worked on by anybody, not just maintainers feature New things to add to Inko, such as a new standard library module std Changes related to the standard library
Milestone

Comments

@yorickpeterse
Copy link
Collaborator

Description

This module method is a bit of a remnant from when we had more module methods for file system operations. In the interest of being consistent and only having one way of doing things, this method should be move to Path.remove as an instance method.

While this seems a bit annoying, it helps keep path related logic in the Path type. This in turn means that if at some point we want to change it to not be backed by a String (#314), we keep all the changes contained to a single type.

Related work

No response

@yorickpeterse yorickpeterse added accepting contributions Issues that are suitable to be worked on by anybody, not just maintainers feature New things to add to Inko, such as a new standard library module std Changes related to the standard library labels Jul 5, 2023
@yorickpeterse yorickpeterse added this to the 0.13.0 milestone Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepting contributions Issues that are suitable to be worked on by anybody, not just maintainers feature New things to add to Inko, such as a new standard library module std Changes related to the standard library
Projects
None yet
Development

No branches or pull requests

1 participant