improve params errors #2437
Merged
improve params errors #2437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
still needs work, I forgot about the warnings we send to stderr like "rung does not cross both rails" and such |
|
And now the electron simulator also shows errors. Lack of any indication of errors has been incredibly confusing for users since the electron simulator was first released.
|
|
@kaalleen Do you think this is ready to go? |
kaalleen
requested changes
Aug 8, 2023
There was a problem hiding this comment.
I love the possibility to see the error message within the params and simulator dialogs.
Seems to be working in Linux, macOS and Windows.
Some error messages are hard to read when they are a longer. Therefore I'd like if we would wrap the text if it is too long. Especially in the simulator window users wouldn't be able to read to whole text if their screens are small.
kaalleen
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Somewhere along the line, the thing that shows a red error message in the Params window when exceptions occur stopped working. This PR fixes that and makes it way more useful. Now, instead of telling them to close the simulator to see the error, the error is shown directly in the Params window.
This way they don't get a spam of errors on stderr that all show up at the end.