Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup document: add option to remove empty groups/layers #2552

Merged
merged 2 commits into from Oct 17, 2023
Merged

Cleanup document: add option to remove empty groups/layers #2552

merged 2 commits into from Oct 17, 2023

Conversation

kaalleen
Copy link
Collaborator

@kaalleen kaalleen commented Oct 14, 2023 •
edited

  • Adds options to remove empty layers and groups
  • Adds option for a test run (do not delete, but display labels and ids of elements/groups to be removed)
    (see feature request Lettering error #2550)

@kaalleen kaalleen mentioned this pull request Oct 14, 2023
Closed
lexelby
lexelby approved these changes Oct 14, 2023
View reviewed changes
Copy link
Member

@lexelby lexelby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Do we need dry run, when the user can just undo?

@kaalleen
Copy link
Collaborator Author

Usually we don't get an output of which elements have been removed, just how many.

@kaalleen kaalleen merged commit 2e648eb into main Oct 17, 2023
5 checks passed
@kaalleen kaalleen deleted the kaalleen/remove-empty-groups branch October 17, 2023 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lexelby lexelby lexelby approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kaalleen @lexelby