-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add randomized running and fill stitches #2830
Conversation
@kaalleen @tyrosinase This is what we discussed earlier in #2281 |
Nice, I do like the random running stitch feature a lot!! |
@@ -374,7 +374,7 @@ def staggers(self): | |||
tooltip=_('The last stitch in each row is quite close to the first stitch in the next row. ' | |||
'Skipping it decreases stitch count and density.'), | |||
type='boolean', | |||
sort_index=26, | |||
sort_index=30, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do hate the sort_index thing so much, even though I'm the one that added it. I can't wait until we redo the GUI entirely.
Nice!! The moire effects have been really bugging me. This produces a much nicer result. It's funny... looking way back at the start of Ink/Stitch, the original fill stitch algorithm used random phase. It gave far lower-quality results with weird banding and moire effects, so I implemented staggering. In this case though, random is much better :) |
@george-steel I feel like I might have missed responding to one of your comments @-mentioning me recently, but I can't find it. If so, could you please point me to it? |
fc2d22b
to
8d7d67b
Compare
All good. Merge when you are ready. |
Add a mode to running stitch that uses randomized phase and stitch length instead of even spacing. This greatly reduces moire effects when stitching closely-spaced curves in running-stitch-based fills.
Add option for randomized running stitch to:
When is randomization is not selected, ripple stitch will use even running stitch when staggers are set to 0 (default) and the stagger algorithm from guided fill (which does not look nice with a stagger period of 0) when staggers is nonzero.
Also includes fix for satin contour underlays (missing tolerance default) mentioned in #2814. This sets the default tolerance to 0.2mm, which is the largest tolerance guaranteed to be backwards-compatible with existing designs using the default inset of 0.4mm.