move print PDF back to web browser #2849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i just tested in on my mac (Monterey), it works fine with firefox, chhrome and safari. |
|
Tested on Firefox, Chrome, Edge and Safari on Linux, macOS and Windows. I pushed to the branch to solve a text wrapping problem which we already faced in the lettering gui for the font description text. |
|
Works on older macOS systems as well. In that case I think we are good to go... |
kaalleen
approved these changes
Apr 23, 2024
|
Thanks for testing, everyone! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The de-electronification continues! This reverts an ancient PR that moved Print PDF over to electron. I had to fix a few things to get everything working in the browser again. Testing welcome, as I've only tested in Firefox.