RFC git-sdk requirements #455
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: b1e354f The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@nikitavoloboev This RFC is work in progress. I intend that we complete the RFC together with your finding and evaluation of isomorphic git vs libgit2. We are facing high ambiguity. Thus, I put the most emphasis on iteration speed and left some notes on what answers I would try to seek from a comparison of a JS vs WebAssembly implementation. |
|
From https://news.ycombinator.com/item?id=35288059. Apparently, EMScripten is unmaintained. If true, this should play a role in our decision process.
|
5 tasks
* refactor: use minimum config schema, remove env from lint * chore: format fix * refactor: only expose 2 query functions * chore: add changeset * chore: remove unnecessary optional chaining * refactor: don't return undefined in lint #453 (comment) * refactor: immutable lint
* fix: linting errors * chore: add changeset
* refactor: remove setup and teardown * work in progress commit * refactor: remove the concept of passing booleans to the lint level * fix: propagation of context Context can't be passed around from nodes to childs without adjusting the target and reference nodes. * chore: simplify type The generic output was unused. * test: slightly more realistic test * refactor: remove context Redundant concept. * init alternative * refactor: define setup function in `LintRule` #459 (comment) * clean up * refactor: remove rule collections 😢 We should wait for user demand to nail a solution. * update readme * refactor: remove unusued utilities The `utilities` lib is intended for external usage. Furthermore, most utilties were not used. * add: typesafety to createLintRule settings * chore: fix type imports * chore: fix typescript compilation * chore: remove test utilities export The utilities like `createMessage` should likely be part of `ast`. Exposing them only for lint seems a short term solution. But, if we expose those utiltites in lint now, we can't remove them in the future. Thus, remove for now. * refactor: return errors to enable apps to handle errors Encountered numerous problems because `lint` implicitly catches errors. That behavior makes sense. Just because one rule is throwing, the linting process shouldn't abort. However, debugging became harder and consuming apps like the editor or CLI will never now if a linting process failed. * fix typo Co-authored-by: Hofer Ivan <ivan.hofer@outlook.com> * fix typo Co-authored-by: Hofer Ivan <ivan.hofer@outlook.com> * show example lint rule with settings * chore: remove todo * fix: only pass message to a node * chore: add comment to remove node types * refactor: narrow settings type * refactor: createLintRule only uses args #459 (comment) * chore: don't use node globals * refactor: remove node dependency entirely node fs imports don't work in core * refactor: remove node dependency entirely node fs imports don't work in core * refactor: remove node dependency entirely node fs imports don't work in core * fix: pass correct args * Create .changeset/hungry-carpets-build.md --------- Co-authored-by: Hofer Ivan <ivan.hofer@outlook.com>
|
Directly committed https://github.com/inlang/inlang/blob/main/rfcs/git-sdk-requirements/RFC.md |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rendered
Give feedback by reviewing the RFC as file link