Fix http pipeline inspect v6.0 #1375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PacketPoolWait in autofp can wait for considerable time. Until now it was essentially spinning, keeping the CPU 100% busy. This patch introduces a condition to wait in such cases. Atomically flag pool that consumer is waiting, so that we can sync the pending pool right away instead of waiting for the MAX_PENDING_RETURN_PACKETS limit.
No MPM though.
Use DETECT_ENGINE_INSPECT_SIG_* instead of 0, 1, 2 and 3.
Only lock f->de_state->m when we start to access it. So after declaration and initialization of local vars.
Add little helper to indicate current tx is that last we have.
Add little helper function StateIsValid() to test if the state can be inspected safely. Cleans up stateful detection loops.
It was effectively unused.
Add API calls for storing detection state in the TX.
Use separate data structures for storing TX and FLOW (AMATCH) detect state. - move state storing into util funcs - remove de_state_m - simplify reset state logic on reload
In case of Detect Reload, we need to reset active tx' state.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes since #1362:
Includes: #1374
Prscript: