stream.inline: add 'auto' mode #152
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stream.inline YAML configuration variable now support the 'auto' value. In this case, inline mode is activated for IPS running mode (NFQ and IPFW) and is deactivated for IDS mode. This patch should fix bug OISF#592.
| if (ConfGet("stream.inline", &temp_stream_inline_str) == 1) { | ||
| /* checking for "auto" and falling back to boolean to provide | ||
| * backward compatibility */ | ||
| if (!strncmp(temp_stream_inline_str, "auto", strlen("auto"))) { |
There was a problem hiding this comment.
I don't like the !strcmp notation, I always read it as "not equal", while it means the opposite. Thats why I always use explicit == 0. Also, why the strNcmp? ConfGet returns a normal string, so a regular strcmp is fine.
There was a problem hiding this comment.
OK, it makes sense. I was not trusting the user received string. But control may have been made previously.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stream.inline YAML configuration variable now support the 'auto' value.
In this case, inline mode is activated for IPS running mode (NFQ and
IPFW) and is deactivated for IDS mode. This patch should fix bug #592.