Next 20160226 v8 #1883
Merged
Next 20160226 v8 #1883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Supported as a custom field.
Remove support for compute capabilities below 2.0. Add capabilities until 5.3.
All variables are initialized thanks to ModbusExtractUint8 or ModbusExtractUint16 function that extracts 8bits or 16bits data from pointer the received input data. In case of extracting error (because of length), ModbusExtractUint8 or ModbusExtractUint16 returns an error that is managed by the caller function. All variables are now initialized to zero when they are declared. It does not change anything functionnally but it removes Modbus warnings.
The check for the return value was wrong, we have 0 for success and 1 (and 2) for the error cases like TM_ECODE_FAILED, so we should quit unless TM_ECODE_OK (0) is returned for NFQInitThread. This fixes #1870
This was referenced Feb 26, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains:
Fixes CUDA compilation and updates 'make install-rules' to use https and get 3.0 version of the ET open rules.
Prscript: