Default iface #261
Closed
Default iface #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch introduces a new set of functions to the ConfGetChildValue family. They permit to look under a default node if looking under base node as failed. This will be used to access to default parameters for a data type (for instance, first usage will be interface).
This patch adds support for 'default' interface which is used to get parameter values when per-interface is not defined.
| @@ -286,6 +286,17 @@ int ConfGetChildValue(ConfNode *base, char *name, char **vptr) | |||
| } | |||
| } | |||
|
|
|||
|
|
|||
| int ConfGetChildValueWithDefault(ConfNode *base, ConfNode *dflt, char *name, char **vptr) | |||
There was a problem hiding this comment.
Can you add unittests for these api additions?
|
Closing for now. I will reopen with unittest and a rebase. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patchset is an implementation of https://redmine.openinfosecfoundation.org/issues/679.
it adds support for a 'default' interface in pcap, pfring and af-packet running mode. If a configuration variable is not set in a per-interface way, the value defined in 'default' interface is used.