Feature/stream state mpm/v29 #2680
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't recursively inspect a detect list if the recursion doesn't increase chance of success.
Add tests for the content inspection engine that count the number of steps it takes to eval a rule.
Content inspection optimization: when just distance is used without within we don't need to search recursively. E.g. content:"a"; content:"b"; distance:1; will scan the buffer for 'a' and when it finds 'a' it will scan the remainder for 'b'. Until now, the failure to find 'b' would lead to looking for the next 'a' and then for 'b' after that. However, we already inspected the entire buffer for 'b', so we know this will fail.
The expression 'isdataat:!1,relative' is used to make sure a match is at the end of a buffer quite often. This patch optimizes this case for 'content' followed by the expression. It enforces it by setting and 'ends with' flag on the content and then taking that flag into account while doing the pattern match.
Merged
|
Merged through #2681 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix various issues with recursive content inspection leading to very bad performance on certain rules.
Related to ticket: https://redmine.openinfosecfoundation.org/issues/2101
Prscript: