detect: fix crash when stream inspect runs on UDP #2811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Certain rules can apply to both TCP and UDP. For example 'alert dns' rules are inspected against both TCP and UDP. This lead to the stream inspect engine being called on a UDP packet. This patch fixes the issue by exiting early from the stream inspect engine if a) proto is not TCP or b) ssn is not available Bug #2158.
victorjulien
added a commit
to victorjulien/suricata
that referenced
this pull request
Feb 16, 2019
Make sure the livedev setup is finalized before initializing the stream engine. Bug OISF#2811 Reported-by: Ad Schellevis
victorjulien
added a commit
to victorjulien/suricata
that referenced
this pull request
Feb 16, 2019
Make sure the livedev setup is finalized before initializing the stream engine. Bug OISF#2811 Reported-by: Ad Schellevis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to redmine ticket: https://redmine.openinfosecfoundation.org/issues/2158
Describe changes:
PRScript output (if applicable):