Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev json http body v26 #2816

Closed
wants to merge 4 commits into from
Closed

Dev json http body v26 #2816

wants to merge 4 commits into from

Conversation

regit
Copy link
Contributor

@regit regit commented Jun 28, 2017

Update of #2808 addressing the remarks.

Link to redmine ticket: https://redmine.openinfosecfoundation.org/issues/2095

Describe changes:

  • Address comments
  • Add doc commit

PRScript output:

Giuseppe Longo and others added 4 commits June 28, 2017 13:51
@regit
output-json-http: add functions to log http body
48f6c0b 
This patch adds two functions that permits to log the http body
in printable or base64 format.
@regit
output-json-alert: log http body
f933756 
Add support for HTTP body logging as printable or as base64.
@regit
output-json-alert: fix error handling
19e70d2 
MemBuffer was not freed in case of allocation error.
@regit
doc: document http-body logging
4b82fa2
@regit
Copy link
Contributor Author

regit commented Jun 28, 2017

Sorry, commit on master in between. The rebase is clean but I can submit a new PR if needed.

@inliniac inliniac mentioned this pull request Jun 28, 2017
Merged
@inliniac
Copy link
Contributor

Merged in #2819, thanks guys!

@inliniac inliniac closed this Jun 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
2 participants
@regit @inliniac