Bug832 #402
Closed
Bug832 #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename all Packet action macro to have them prefixed by PACKET.
PACKET_* are now wrapper to the newly introduced PACKET_SET_ACTION macro.
Setting the ACTION_DROP flag can be done via PACKET_DROP instead of using PACKET_UPDATE_ACTION.
|
I think we need to inspect things that are most likely to discard a rule early first, as most rules don't completely match. Also, IIRC in the past there was a somewhat obscure relation between these MATCH matches and stateful detection. So a lot of testing/validation/profiling would be needed before this can go in. |
|
I don't think I've changed any logic here but in the last patch. If we have any doubt on it I propose to discard it as it is fundamentally not a must have. |
|
Seems my comment is in the wrong pr :) |
|
Merged, thanks Eric. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements bug 832 which is a cleaning work on PACKET macros.