Bug797 #421
Closed
Bug797 #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch adds a script which can be used to generate a test on coherence of flag usage. By adding comment in the code, it is possible to declare that we link a flag in a structure to a specific family of constant: For example: /* coccinelle: Packet:flowflags:FLOW_PKT_ */ will trigger the generation on a test which verifies that the flowflags field in Packet structure is only used with constant starting by FLOW_PKT_.
This patch modify build system to have make to create the struct-flags.cocci file by running struct-flags.py. This way 'make check' is running the test defined from source code.
There is no reason not to update the flag directly. So do it to avoid to crash the test.
|
Merged, thanks Eric. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's an implementation for bug 797.