Bug1067 v1.1 #747
Closed
Bug1067 v1.1 #747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch introduces wrapper functions around allocation functions to be able to have a global HTP memcap. A simple subsitution of function was not enough because allocated size needed to be known during freeing and reallocation. The value of the memcap can be set in the YAML and is left by default to unlimited (0) to avoid any surprise to users.
This patch adds a memory counter for HTP memory usage. As there is no thread variables available in application layer the counter has been added to the TCP reassembly thread.
This patch adds a memcap counter for HTP memory usage. Counter is increased each time an allocation is not done due to the memcap.
Merged
|
Merged through #758 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's an implementation of HTTP memcap. It puts a memcap on all allocations made for HTP by using dedicated allocation function. Two last commits implements some counters (memuse and memcap hit).
PR builds:
Ticket: https://redmine.openinfosecfoundation.org/issues/1067