Exit message #748
Closed
Exit message #748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch adds a cleaning function to device list. This also permits to display per-interface statistics during the exit.
This patch updates capture modes not using LiveDecice counters to display per-thread exit statistics with default verbosity.
Live device counter was in fact the number of packets seen by suricata and not the total number of packet reported by kernel. This patch fixes this by using counter provided by kernel instead. The counter is Clear On Read, so by adding the value fetch at each call and earch sockets we get the number of packets and drops for the interface.
Live device counter was in fact the number of packets seen by suricata and not the total number of packet reported by pfring. This patch fixes this by using counter provided by kernel instead. Pfring kernel counter is per socket and is not cleared after read. So to get the number of packet on the interface we can add the new value for this thread and add it to the interface counter.
Merged
|
Merged through #757 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's a PR which improve the exit message of suricata by adding the packets and drop counters. Two last commits are fixes for the live device counters which were not correctly computed.
PR builds:
Ticket: https://redmine.openinfosecfoundation.org/issues/894