dns memcap v0.3 #789
Merged
dns memcap v0.3 #789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yaml layout changed. DNS had to be updated to retrievel value for dns flood from the correct location in the config tree.
Add per state and global memcap option parsing.
Add memuse tracking and memcap checking to the DNS parsers. Memuse is tracked globally and per flow (state). Memcaps are also checked per flow and globally before memory allocs are done.
To be able to register counters from AppLayerGetCtxThread, the ThreadVars pointer needs to be available in it and thus in it's callers: - AppLayerGetCtxThread - DecodeThreadVarsAlloc - StreamTcpReassembleInitThreadCtx
Update AppLayerHandleUdp to take the ThreadVars pointer as an argument in prepraration of handling counters in this function.
Register dns memory counters. Keep track of memcap reached conditions, and increment counters for those.
This patch updates the DNS counters from the main AppLayer entry functions. Due to the limited scope of AppLayerThreadCtx some of the logic had to be implemented in app-layer.c, where it doesn't belong.
Raise event if state-memcap is reached for a flow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#788 with event support.
Prscript: