Bug1111 #858
Merged
Bug1111 #858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Packets counter is incremented in AFPDumpCounters and it was also incremented during packet reading. The result was a value that is twice the expected result. Spotted-by: Victor Julien <victor@inliniac.net>
Some of the packets counters were using a 32bit integer. Given the bandwidth that is often seen, this is not a good idea. This patch switches to 64bit counter.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first patch is a fix for bug 1111. The second converts the packets counter to 64bits integer to avoid a potential overflow on busy boxes.
Redmine ticket: https://redmine.openinfosecfoundation.org/issues/1111
PR builds: