Ips stats v1.2 #864
Closed
Ips stats v1.2 #864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reference to Pcap was not correct.
In the case of running mode like NFQ there is no need possibility to compute the statistics as it is done in LiveDevice (drop and checksum count are meaningless). This patch adds a function that allow running mode to disable the display of the counters at exit.
This patch adds call to the function used to disable the display of live device stats at exit.
This patch updates the message displayed at exit to have something more readable.
This patch adds call to the function used to disable the display of live device stats at exit.
This patch synchronizes the exit message with what is done in NFQ capture mode.
Fix warning spotted by clang on FreeBSD:
source-ipfw.c:241:49: warning: use of logical '||' with constant operand [-Wconstant-logical-operand]
if (suricata_ctl_flags & (SURICATA_STOP || SURICATA_KILL)) {
^ ~~~~~~~~~~~~~
source-ipfw.c:241:49: note: use '|' for a bitwise operation
if (suricata_ctl_flags & (SURICATA_STOP || SURICATA_KILL)) {
^~
|
Use same logic as the one used in other capture mode.
| { | ||
| live_devices_stats = 0; | ||
|
|
||
| return 1; |
There was a problem hiding this comment.
return 1 in a void function? :)
There was a problem hiding this comment.
I'll fix this up at merge.
|
Merged after rebase and fixing up that return 1. Thanks Eric. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated PR #860 with only a change in function name and type.
Redmine tickets: https://redmine.openinfosecfoundation.org/issues/1115
PR builds: