Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for #558. #96

Closed
wants to merge 1 commit into from
Closed

fix for #558. #96

wants to merge 1 commit into from

Conversation

poona
Copy link
Contributor

@poona poona commented Sep 25, 2012

  • Fast pattern analysis now a part of engine analysis.
  • Warn users if a stream fast pattern is set, but the sig matches on http.

- Fast pattern analysis now a part of engine analysis.
- Warn users if a stream fast pattern is set, but the sig matches on http.
if (rule_engine_analysis_set) {
SigGroupHead sh;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There must be a cleaner way to handle this.

@inliniac
Copy link
Contributor

This pr goes far beyond what was meant to be done as I explain here: https://redmine.openinfosecfoundation.org/issues/558#note-2

@inliniac inliniac closed this Sep 26, 2012
@poona
Copy link
Contributor Author

poona commented Sep 26, 2012

On Wed, Sep 26, 2012 at 1:11 PM, Victor Julien notifications@github.comwrote:

This pr goes far beyond what was meant to be done as I explain here:
https://redmine.openinfosecfoundation.org/issues/558#note-2


Reply to this email directly or view it on GitHubhttps://github.com//pull/96#issuecomment-8881568.

Yes. If the rule analysis requires printing fast_pattern and the buffer it
works on, we might as well print another 3-4 lines and describe the
fast_pattern. And it's also indented to show it's a separate section.

This is much better imo. If you are inspecting 1000 rules and you are in
the middle of a rule_analysis_file checking out sid xx. Now you want to
check the fast pattern analysis for xx, you will have to open the other
file, and search for sid xx in the file. It's much simpler now imo.

Anoop Saldanha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants