Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve performance of SourceInfo.get_siblings #7040

Closed
wouterdb opened this issue Jan 24, 2024 · 2 comments
Closed

improve performance of SourceInfo.get_siblings #7040

wouterdb opened this issue Jan 24, 2024 · 2 comments
Assignees
@wouterdb

Comments

@wouterdb
Copy link
Contributor

When running on larger modules, it seems that SourceInfo.get_siblings in the code upload service causes significant load

image

We should investigate if this code can be made more efficient (I suspect we now search the same siblings over and over again)
@wouterdb
Copy link
Contributor Author

wouterdb commented Feb 6, 2024

Hey team! Please add your planning poker estimate with Zenhub @arnaudsjs @FloLey @Hugo-Inmanta @sanderr

@sanderr
Copy link
Contributor

sanderr commented Feb 6, 2024

May or may not be easier to call into Module.get_python_files()

@wouterdb wouterdb self-assigned this Feb 8, 2024
@wouterdb wouterdb mentioned this issue Feb 8, 2024
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wouterdb wouterdb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Removed get siblings inmanta/inmanta-core
2 participants
@wouterdb @sanderr