Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RoutingConstraints conflict with language codes contained in routes #411

Open
fabianzwodrei opened this issue Sep 7, 2020 · 1 comment

Comments

@fabianzwodrei
Copy link

fabianzwodrei commented Sep 7, 2020

Using languages like 'ar' for labels conflict with the routes and the routing contraints, where string 'ar' is matching the 'search' route - 'search' will be treated as a :lang.

The regex in the routing_constraint of lib/iqvoc/configuration/core.rb could be:

params[:lang].to_s =~ /^(#{langs})$/

@mjansing
Copy link
Contributor

mjansing commented Jan 4, 2021

Hi @fabianzwodrei,

thanks for reporting. Can you supply a test case for your issue? Currently I don't know what's exactly wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants