Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Second import repeats labels #438

Open
EwaSniegowskaPCSS opened this issue Jul 7, 2022 · 0 comments
Open

Second import repeats labels #438

EwaSniegowskaPCSS opened this issue Jul 7, 2022 · 0 comments

Comments

@EwaSniegowskaPCSS
Copy link

  1. I import data. Example data:
<https://opensubjects.org/terms/lego_brick> <http://www.w3.org/1999/02/22-rdf-syntax-ns#type> <http://www.w3.org/2004/02/skos/core#Concept> .
<https://opensubjects.org/terms/lego_brick> <http://www.w3.org/2004/02/skos/core#topConceptOf> <https://opensubjects.org/terms/scheme> .
<https://opensubjects.org/terms/lego_brick> <http://www.w3.org/2004/02/skos/core#inScheme> <https://opensubjects.org/terms/scheme> .
<https://opensubjects.org/terms/lego_brick> <http://www.w3.org/2004/02/skos/core#prefLabel> "klocek LEGO"@pl .
<https://opensubjects.org/terms/lego_brick> <http://www.w3.org/2004/02/skos/core#altLabel> "klocuszek LEGO"@pl .
<https://opensubjects.org/terms/lego_brick> <http://www.w3.org/2004/02/skos/core#prefLabel> "LEGO brick"@en .
  1. I import same data again. No new concepts added (expected).
    Preferred and alternative labels in concepts are duplicated (not expected).
    I attach the screenshot.
    doublelabels
  2. I export data. Labels are also duplicated in exported data
    (not expected, but not a big problem).

I think adding new labels for alreading existing concepts is useful,
for example if you enriched the imported data with new labels, from new languages, etc.
But duplicating labels is not necessary, it also causes problems
with consistency check for a concept. You get errors:

"The alternative label %{label} is used twice."
"There must be only one preferred Label per language."

I think it would be better if iQvoc compared strings during import
and not added duplicated labels (maybe if preferred label does not match
it should be overriden?).

Is the described behaviour intended or it needs fixing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant