Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Framework feature enhancements refactoring #37

Merged
merged 13 commits into from Aug 16, 2022
Merged

Framework feature enhancements refactoring #37

merged 13 commits into from Aug 16, 2022

Conversation

bhangeprashant
Copy link
Collaborator

Feature Enhancements, Code Refactoring and Issue fixes

  1. rest-assured support added for API Automation
  2. HikariCP Support added to handle multiple databases
  3. New Property "AUT" added to toggle between UI and API Automation
  4. Fix provided for Issue Sample maven project "orange-hrm" is not getting built properly when imported #34, Issue Logger is not printing info and error logs of Framework execution in console #35 , Issue ApplitoolEyeConfig.properties "EYE_ENABLE" has default value set as TRUE in sample project, it should be FALSE and should be set as TRUE whenever Applitools features are used #36
  5. Updated Logger info
  6. Required dependencies added
  7. Bump up framework version

Prashant and others added 13 commits August 14, 2022 14:49
HikariCP Support added to handle multiple DBs
3cacb77
Replaced ApplitoolEyes with recent ApplitoolEyesWeb
4ab8724
Added support for API Automation using rest-assured
680a92d
Provided fix for Issue #36, added log4j.properties file
ef8e7cb
Replaced sysouts with logger
e68de53
Provided fix for Issue #36, Updated EYE_ENABLE as FALSE as Default
741957a
Sysouts replaced with Logger
6b5c152
Replaced Sysouts with Logger
56bdcef
Changes as below
6d86dc3 
-New Property "AUT" added to toggle between UI and API Automation
-In Listner added condition to check AUT property value
-Added SuppressWarnings wherever needed
Properties info modified
b116cb0
Dependecies rest-assured and json added to support API Automation
8c493c5
@zodgevaibhav
Bumpup version of framework and logs config
df87936
@zodgevaibhav
Use updated framework
f30c39c
@zodgevaibhav zodgevaibhav self-requested a review August 16, 2022 12:20
zodgevaibhav
zodgevaibhav approved these changes Aug 16, 2022
View reviewed changes
Copy link
Collaborator

@zodgevaibhav zodgevaibhav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes approved

@zodgevaibhav zodgevaibhav merged commit 595a578 into main Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zodgevaibhav zodgevaibhav zodgevaibhav approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bhangeprashant @zodgevaibhav