New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unique name for each plugin instance #19
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mockersf
force-pushed
the
unique-plugin-by-name
branch
from
November 20, 2022 10:38
1732113
to
470bae4
Compare
Interesting. OK, i like this, helps improve correctness. Merging the PR, but im not sure this is worth making another release for... 🤔 |
inodentry
added a commit
that referenced
this pull request
May 6, 2023
* fix assets tracking logic * depend on bevy main * Udate to latest Bevy main; prep for 0.8 (#16) * Update to latest Bevy commit * Manually derive StageLabel * Do not pin the Bevy commit * Cargo.toml: point back at non-forked iyes_loopless Co-authored-by: Ida Iyes <40234599+inodentry@users.noreply.github.com> * loopless moved some things around * v0.4: Bevy 0.8 * refactor things conditional on loopless into separate files * implement "hidden progress" * abstract progress return types with a trait * add hidden progress to example * add dummy systems, they might be useful to someone * version bump to 0.5.0 * update to iyes_loopless 0.8 * version bump to 0.6.0 * bevy 0.9 compat * Mark progress plugin as not unique (#18) * Version bump to 0.7.1 * unique name for each plugin instance (#19) * add note about issue #20 * Bump Bevy to main 0.11-dev --------- Co-authored-by: Ida Iyes <identry@protonmail.com> Co-authored-by: Niklas Eicker <git@nikl.me> Co-authored-by: Ida Iyes <40234599+inodentry@users.noreply.github.com> Co-authored-by: François <mockersf@gmail.com>
NiklasEi
added a commit
to NiklasEi/iyes_progress
that referenced
this pull request
Oct 21, 2023
* fix assets tracking logic * depend on bevy main * Udate to latest Bevy main; prep for 0.8 (IyesGames#16) * Update to latest Bevy commit * Manually derive StageLabel * Do not pin the Bevy commit * Cargo.toml: point back at non-forked iyes_loopless Co-authored-by: Ida Iyes <40234599+inodentry@users.noreply.github.com> * loopless moved some things around * v0.4: Bevy 0.8 * refactor things conditional on loopless into separate files * implement "hidden progress" * abstract progress return types with a trait * add hidden progress to example * add dummy systems, they might be useful to someone * version bump to 0.5.0 * update to iyes_loopless 0.8 * version bump to 0.6.0 * bevy 0.9 compat * Mark progress plugin as not unique (IyesGames#18) * Version bump to 0.7.1 * unique name for each plugin instance (IyesGames#19) * add note about issue IyesGames#20 * Bump Bevy to main 0.11-dev --------- Co-authored-by: Ida Iyes <identry@protonmail.com> Co-authored-by: Niklas Eicker <git@nikl.me> Co-authored-by: Ida Iyes <40234599+inodentry@users.noreply.github.com> Co-authored-by: François <mockersf@gmail.com>
inodentry
added a commit
that referenced
this pull request
Feb 18, 2024
* Update to latest Bevy main 0.11 (#23) * fix assets tracking logic * depend on bevy main * Udate to latest Bevy main; prep for 0.8 (#16) * Update to latest Bevy commit * Manually derive StageLabel * Do not pin the Bevy commit * Cargo.toml: point back at non-forked iyes_loopless Co-authored-by: Ida Iyes <40234599+inodentry@users.noreply.github.com> * loopless moved some things around * v0.4: Bevy 0.8 * refactor things conditional on loopless into separate files * implement "hidden progress" * abstract progress return types with a trait * add hidden progress to example * add dummy systems, they might be useful to someone * version bump to 0.5.0 * update to iyes_loopless 0.8 * version bump to 0.6.0 * bevy 0.9 compat * Mark progress plugin as not unique (#18) * Version bump to 0.7.1 * unique name for each plugin instance (#19) * add note about issue #20 * Bump Bevy to main 0.11-dev --------- Co-authored-by: Ida Iyes <identry@protonmail.com> Co-authored-by: Niklas Eicker <git@nikl.me> Co-authored-by: Ida Iyes <40234599+inodentry@users.noreply.github.com> Co-authored-by: François <mockersf@gmail.com> * Update to Bevy main 0.13 * Bump version for Bevy 0.13 * Bump Bevy dependency to 0.13 --------- Co-authored-by: José Pazos Pérez <jose.pazos.perez@rai.usc.es> Co-authored-by: Ida Iyes <identry@protonmail.com> Co-authored-by: Ida Iyes <40234599+inodentry@users.noreply.github.com> Co-authored-by: François <mockersf@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of marking the plugin as not unique, give it a unique name depending on the state it's loading in.
This means that
will work, but
won't, blocking adding by mistake the plugin twice with the same state