Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

to_date throws error if there is no date #50

Closed
arrk-shoba opened this issue Aug 1, 2012 · 3 comments
Closed

to_date throws error if there is no date #50

arrk-shoba opened this issue Aug 1, 2012 · 3 comments

Comments

@arrk-shoba
Copy link

Hi,
Thanks for adding date in accepted params.

There is an issue with the same. If we pass correct date, it works correctly. However, if there is no date data in the SOAP request, to_date validation error is thrown. We can possibly check, if data is nil, we need not do to_date.

@arrk-shoba
Copy link
Author

This is an issue especially if the date is not a mandatory element in the SOAP request.

@dhinus
Copy link
Contributor

dhinus commented Aug 4, 2012

I had a very similar issue, and fixed it with this patch:
cayenne-digital/wash_out@8b3f90d

I would like to do more research before opening a pull request, because I'm not sure this is the "right way" (is there anything "right" in SOAP actually?) but check if it does solve your problem.

@dhinus
Copy link
Contributor

dhinus commented Aug 4, 2012

sorry, your problem is in the request while mine was in the response, so my patch is useless in your case... but i think wash_out is not handling nil values correctly in both directions.

we should probably check the "xs:nil" attribute in the request, does your client append it when the date field is empty?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants