Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nori 2.0 breaks washout #77

Closed
rubiii opened this issue Dec 27, 2012 · 2 comments
Closed

nori 2.0 breaks washout #77

rubiii opened this issue Dec 27, 2012 · 2 comments

Comments

@rubiii
Copy link

rubiii commented Dec 27, 2012

hey boris,

the recent release of nori 2.0 comes with backward incompatible changes to the public api.
i would recommend changing your gemspec and pin down nori to 1.x.

related: savonrb/savon#351

cheers,
daniel

@rubiii
Copy link
Author

rubiii commented Dec 27, 2012

just noticed that washout doesn't specify versions for all its dependencies.

you're probably not noticing any problems, because you're using a Gemfile.lock with your gem, which pins down the versions of nori (and savon) to use. i would not suggest relying on the lockfile for gem development, as it doesn't reflect actual usage.

at least not, if the lockfile doesn't cover versions allowed by the gemspec.

@inossidabile
Copy link
Owner

I attempted to migrate to Nori 2 but it appeared to be broken: savonrb/nori#29 😱 So I added explicit version dependency and released the hot-fix.

What you did in the second branch of your "savon and company" tools is awesome! I can't hardly wait to get an ability to upgrade dependency and release 0.6.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants