Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(patch-request): hide ryd separator #101

Closed
3 tasks done
Spacellary opened this issue Jan 5, 2023 · 16 comments
Closed
3 tasks done

feat(patch-request): hide ryd separator #101

Spacellary opened this issue Jan 5, 2023 · 16 comments
Labels
Feature request Requesting a new feature

Comments

@Spacellary
Copy link
Collaborator

Spacellary commented Jan 5, 2023

Application

YouTube

Issue

This is of course subjective but I prefer the way it was before the update, without the | after the like symbol. I get it's supposed to "mirror" the other side and be symmetrical but it just looks off, and as long as both sides can't be completely equal the previous way was cleaner IMO... So I ask:

Patch

RYD Related, Like Button Adjustment:
Remove the | after the like symbol in the Like Button Container

Motivation

Previous implementation looks (subjectively) cleaner until there's proper symmetry, and the added | character doesn't match the counterpart in tbe slightest...

Screenshot_2023-01-05-05-03-55-189_app rvx android youtube

Acknowledgements

  • I have searched the existing issues and this is a new and no duplicate or related to another open issue.
  • I have written a short but informative title.
  • I filled out all of the requested information in this issue properly.
@Spacellary Spacellary added the Feature request Requesting a new feature label Jan 5, 2023
@YT-Advanced
Copy link

Can u send your device name, because my own is working well :D
image

@Spacellary
Copy link
Collaborator Author

Heya! Sorry, should have added that!

Device: Xiaomi Redmi Note 11
Android: 12 (MIUI 13)
System font: MiSans (it's the default one)

@Spacellary
Copy link
Collaborator Author

Spacellary commented Jan 6, 2023

Built with latest recommended YouTube version and latest Patches version:

Screenshot_2023-01-06-07-59-41-781_app rvx android youtube

Screenshot_2023-01-06-08-04-22-839_com miui securitycenter
Screenshot_2023-01-06-08-02-58-888_app rvx android youtube

@inotia00
Copy link
Owner

inotia00 commented Jan 6, 2023

Unfortunately, this feature varies depending on the manufacturer of the device you use

The first person who suggested this function does not seem to support Xiaomi device

@YT-Advanced
Copy link

Hmm, look like the Google layout doesn't take effect on your device. I will send your suggestion to Revanced Team (they create this feature, not me or inotia00)

@YT-Advanced
Copy link

Unfortunately, this feature varies depending on the manufacturer of the device you use

The first person who suggested this function does not seem to support Xiaomi device

I think the font cause this bug, but I don't have Xiaomi device for testing :(

@Spacellary
Copy link
Collaborator Author

Spacellary commented Jan 6, 2023

I tried 2 other fonts and I had the same results.
The | did look a bit different with each one, but still looks completely weird.

If you want I can try a font of your suggestion and see if that works.

@inotia00 inotia00 changed the title feat(patch-adjustment): RYD Related, Like Button Adjustment, Remove the |... feat(patch-request): hide ryd separator Jan 6, 2023
@inotia00
Copy link
Owner

inotia00 commented Jan 6, 2023

Will be added in next releases
(Already reflected in commit)

@inotia00
Copy link
Owner

inotia00 commented Jan 7, 2023

added in revanced-patches-v2.152.6

@inotia00 inotia00 closed this as completed Jan 7, 2023
@Spacellary
Copy link
Collaborator Author

Thanks for the quick and hard work as always @inotia00

@Spacellary
Copy link
Collaborator Author

Spacellary commented Jan 7, 2023

I'll just report for future reference that with YouTube v18.01.33 (beta) and latest 1.152.6 patches the like/dislikes now look like this, so already better, even if I still prefer disabled for now...
...
Font MiSans:
Screenshot_2023-01-07-02-13-36-939_app rvx android youtube

@inotia00
Copy link
Owner

inotia00 commented Jan 7, 2023

ryd
@Spacellary Did you change this value to off?

@Spacellary
Copy link
Collaborator Author

Did you change this value to off?

Just for the screenshot! I've changed it to ON now and it's fine! Should have been more clear xD

@Spacellary
Copy link
Collaborator Author

I'm testing other fonts now! Seems promising!

@inotia00
Copy link
Owner

inotia00 commented Jan 7, 2023

goood

@Spacellary
Copy link
Collaborator Author

Spacellary commented Jan 7, 2023

The font "OpenSans" seemed to work almost perfectly too when applied and after toggling the separator on and off. But upon further examination, after restarting the app it doesn't stay that way, it reverted to the ugly way like before for me. So I'll give this up for now, honestly as long as you can hide the separator (thanks again for the quick Patch!) I'm happy.
Of course, I share any news and I'm always available if testing is needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature request Requesting a new feature
Projects
None yet
Development

No branches or pull requests

3 participants