Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

youtube - hide player button background makes the player overlay lag #1679

Closed
4 of 5 tasks
MondayNitro opened this issue Nov 12, 2023 · 6 comments
Closed
4 of 5 tasks
Labels
Bug report Something isn't working

Comments

@MondayNitro
Copy link

MondayNitro commented Nov 12, 2023

Type

Cosmetic

Tools used

RVX Manager

Application

youtube 18.43.45

Bug description

when you include hide player overlay patch and enable it, the player overlay does not not appear smoothly, it gets a bit dark at first, then darker. if ypu dont enable it, then the issue doesnt occur.

im not sure if this issue existed earlier because i always used force hide background patch until now.

Steps to reproduce

  • include hide player overlay patch and enable it
  • the player overlay does not not appear smoothly if you tap the player screen

Relevant log output

.

Screenshots or videos

HIDE PLAYER BUTTON BACKGROUND INCLUDED AND ENABLED

with.mp4

HIDE PLAYER BUTTON BACKGROUND INCLUDED BUT DISABLED

without.mp4

Solution

No response

Additional context

No response

Device Environment

los20

Acknowledgements

  • I have searched the existing issues and this is a new and no duplicate or related to another open issue.
  • I have written a short but informative title.
  • I filled out all of the requested information in this issue properly.
  • I have written the title and contents in English.
  • This issue does not reproduce on unpatched YouTube or YT Music.
@MondayNitro MondayNitro added the Bug report Something isn't working label Nov 12, 2023
@KobeW50
Copy link
Contributor

KobeW50 commented Nov 12, 2023

This was why the Force hide player button background patch was introduced, but it's been deprecated.

You can read more about it in #1638 (comment) and in #569.

I'll wait for inotia00 to close this in case he wants to provide more information on the issue.

@inotia00 inotia00 closed this as not planned Won't fix, can't repro, duplicate, stale Nov 12, 2023
@inotia00
Copy link
Owner

sry I closed the issue by mistake

@inotia00 inotia00 reopened this Nov 12, 2023
@inotia00
Copy link
Owner

I'll add the Force hide player button background patch again, and remove the Hide player button background patch

@Kuddus73
Copy link

Wasn't Force hide player button background patch deprecated?
If it isn't, why not keep both patches as before?

@inotia00
Copy link
Owner

I thought there was no need for duplicate patches to exist, so I deperated one of them and removed the patch.

The Force hide player button background patch is not buggy, and the Hide player button background patch is buggy.

Therefore, it is more appropriate to deperate the Hide player button backgroundpatch and restore the Force hide player button background patch.

@inotia00
Copy link
Owner

reflected in revanced-patches-v2.196.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug report Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants