Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(YouTube): Force fullscreen patch is getting failed while patching #1766

Closed
5 tasks done
sams452m opened this issue Dec 1, 2023 · 2 comments
Closed
5 tasks done
Labels
Bug report Something isn't working

Comments

@sams452m
Copy link

sams452m commented Dec 1, 2023

Type

Error while patching

Tools used

Revancify

Application

YouTube v18.38.45

Bug description

While patching YouTube through revancify the
Force fullscreen patch is getting failed.

Error logs

SEVERE: Force fullscreen failed:
app.revanced.patcher.patch.PatchException: Failed to resolve VideoPortraitParentFingerprint
	at app.revanced.extensions.ExtensionsKt.getException(Extensions.kt:34)
	at app.revanced.patches.youtube.fullscreen.forcefullscreen.ForceFullscreenPatch.execute(ForceFullscreenPatch.kt:112)
	at app.revanced.patches.youtube.fullscreen.forcefullscreen.ForceFullscreenPatch.execute(ForceFullscreenPatch.kt:22)
	at app.revanced.patcher.Patcher$apply$1.invokeSuspend$executePatch(Patcher.kt:174)
	at app.revanced.patcher.Patcher$apply$1.invokeSuspend(Patcher.kt:203)
	at app.revanced.patcher.Patcher$apply$1.invoke(Patcher.kt)
	at app.revanced.patcher.Patcher$apply$1.invoke(Patcher.kt)
	at kotlinx.coroutines.flow.SafeFlow.collectSafely(Builders.kt:61)
	at kotlinx.coroutines.flow.AbstractFlow.collect(Flow.kt:230)
	at app.revanced.cli.command.PatchCommand$run$4$patcherResult$1$1.invokeSuspend(PatchCommand.kt:304)
	at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
	at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:108)
	at kotlinx.coroutines.EventLoopImplBase.processNextEvent(EventLoop.common.kt:280)
	at kotlinx.coroutines.BlockingCoroutine.joinBlocking(Builders.kt:85)
	at kotlinx.coroutines.BuildersKt__BuildersKt.runBlocking(Builders.kt:59)
	at kotlinx.coroutines.BuildersKt.runBlocking(Unknown Source)
	at kotlinx.coroutines.BuildersKt__BuildersKt.runBlocking$default(Builders.kt:38)
	at kotlinx.coroutines.BuildersKt.runBlocking$default(Unknown Source)
	at app.revanced.cli.command.PatchCommand.run(PatchCommand.kt:303)
	at picocli.CommandLine.executeUserObject(CommandLine.java:2026)
	at picocli.CommandLine.access$1500(CommandLine.java:148)
	at picocli.CommandLine$RunLast.executeUserObjectOfLastSubcommandWithSameParent(CommandLine.java:2461)
	at picocli.CommandLine$RunLast.handle(CommandLine.java:2453)
	at picocli.CommandLine$RunLast.handle(CommandLine.java:2415)
	at picocli.CommandLine$AbstractParseResultHandler.execute(CommandLine.java:2273)
	at picocli.CommandLine$RunLast.execute(CommandLine.java:2417)
	at picocli.CommandLine.execute(CommandLine.java:2170)
	at app.revanced.cli.command.MainCommandKt.main(MainCommand.kt:12)

Solution

No response

Additional context

No response

Device Environment

No response

Acknowledgements

  • This issue does not reproduce on unpatched YouTube or YT Music.
  • This issue is not a duplicate of an existing bug report.
  • I have chosen an appropriate title.
  • All requested information has been provided properly.
  • I have written the title and contents in English.
@sams452m sams452m added the Bug report Something isn't working label Dec 1, 2023
@sams452m sams452m changed the title bug(YouTube): 'Force fullscreen' patch is getting failed while patching bug(YouTube): Force fullscreen patch is getting failed while patching Dec 1, 2023
@inotia00
Copy link
Owner

inotia00 commented Dec 2, 2023

It will be fix in the next release
Exclude the patch or try to patch with the latest YouTube

@inotia00
Copy link
Owner

inotia00 commented Dec 2, 2023

reflected in revanced-patches-v2.201.12

@inotia00 inotia00 closed this as completed Dec 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug report Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants