Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Reddit): add Change package name patch #1842

Closed
5 tasks done
nikhilbadyal opened this issue Dec 22, 2023 · 5 comments
Closed
5 tasks done

feat(Reddit): add Change package name patch #1842

nikhilbadyal opened this issue Dec 22, 2023 · 5 comments
Labels
Feature request Requesting a new feature

Comments

@nikhilbadyal
Copy link

nikhilbadyal commented Dec 22, 2023

Application

Reddit

Feature description

Google made some in recent days and now modded apps also show up in Play Store Update menu. This is creating an issue for reddit app.

Can we migrate this patch from Revanced to change package for Reddit Extended? Or a new patch for Reddit also like YT & YT Music.

Motivation

After being shown in Play Store it's annoying and wastes bandwidth as even if we click on update in Playstore. It downloads the update and fails in the end.

Acknowledgements

  • This is not a feature request for YouTube.
  • This issue is not a duplicate of an existing feature request.
  • I have chosen an appropriate title.
  • All requested information has been provided properly.
  • I have written the title and contents in English.
@nikhilbadyal nikhilbadyal added the Feature request Requesting a new feature label Dec 22, 2023
@inotia00
Copy link
Owner

I haven't tested that patch
iirc in certain apps, force close occurred when changing the package name

@nikhilbadyal
Copy link
Author

It works for reddit atleast ig. As per reddit discussions.

@inotia00
Copy link
Owner

inotia00 commented Dec 23, 2023

I have finished testing to implement this patch.

I was able to implement the patch in two ways, and Pros and Cons according to each method are as follows.

Method 1. The 'Change package name' patch provided by the official ReVanced Patches
: This only changes AndroidManifest's 'package' name.

  • Pros: Available in RVX Manager and CLI.
  • Cons: Unlike YouTube or YT Music, you could not install multiple Reddit apps.

Method 2. The 'Change package name' patch that has been improved a bit on my side
: Change not only AndroidManifest's 'package' name, but also the permissions and provider's package name.

  • Pros: You can install multiple Reddit apps, such as YouTube or YT Music.
  • Cons: Not available in RVX Manager.

I decided to combine Method 1 and Method 2.

In other words, if you try patching in RVX Manager, Method 1 will be applied.
If you try patching in Revancify, rvx-builder, or CLI, Method 2 will be applied.

This will be reflected in the next release.

@inotia00 inotia00 changed the title feat: Change Package Name Patch Support feat(Reddit): add Change package name patch Dec 23, 2023
@nikhilbadyal
Copy link
Author

nikhilbadyal commented Dec 23, 2023

I always use cli. Anyways good that you decided to go ahead with 1 & 2 both.

@inotia00
Copy link
Owner

reflected in revanced-patches-v2.207.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature request Requesting a new feature
Projects
None yet
Development

No branches or pull requests

2 participants