Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suggestion(RVX Manager): Remove Show universal patches #2211

Closed
5 tasks done
ILoveOpenSourceApplications opened this issue Jul 2, 2024 · 7 comments
Closed
5 tasks done
Labels
Suggestion Leave any other suggestions

Comments

@ILoveOpenSourceApplications

Application

Other

Suggestion description

As RVX doesn't support any universal patches, it's an obsolete option and removing it would make sense.

Acknowledgements

  • This issue is not a duplicate of an existing suggestion.
  • This is not a feature request.
  • I have chosen an appropriate title.
  • All requested information has been provided properly.
  • I have written the title and contents in English.
@ILoveOpenSourceApplications ILoveOpenSourceApplications added the Suggestion Leave any other suggestions label Jul 2, 2024
@KobeW50
Copy link
Contributor

KobeW50 commented Jul 2, 2024

People can change the source in the Manager to one with universal patches, so keeping the option there can be useful.

@Kuddus73
Copy link

Kuddus73 commented Jul 2, 2024

it's an obsolete option and removing it would make sense.

Why would it make sense to remove a useful feature?

People can change the source in the Manager to one with universal patches

Exactly.

@ILoveOpenSourceApplications
Copy link
Author

Quoting inotia00
"RVX Manager is provided simply for compatibility with my patch, if you run into issues follow the other patch method."

Also, If you're someone using universal patches you can install ReVanced Manager as well.

@KobeW50
Copy link
Contributor

KobeW50 commented Jul 3, 2024

Quoting inotia00
"RVX Manager is provided simply for compatibility with my patch, if you run into issues follow the other patch method."

At that point, you can even remove all of the Alternative sources options and have it always set to inotia00.

Forks of RVX recommend patching on the RVX Manager instead of the ReVanced Manager (likely for the same reason the RVX Manager was created for)

And it doesn't make sense for inotia00 to put in work to remove a feature that doesn't cause any issues.

@Kuddus73
Copy link

Kuddus73 commented Jul 3, 2024

Quoting inotia00
"RVX Manager is provided simply for compatibility with my patch, if you run into issues follow the other patch method."

Also, If you're someone using universal patches you can install ReVanced Manager as well.

Why would I install another app if the same app can do it without any issues?
You are seeing problems where there aren't any.

At that point, you can even remove all of the Alternative sources options and have it always set to inotia00.

And it doesn't make sense for inotia00 to put in work to remove a feature that doesn't cause any issues.

Again, exactly.

@ILoveOpenSourceApplications
Copy link
Author

It's a suggestion after all, and if inotia00 agrees it'll get removed and if not, it'll stay.

@inotia00
Copy link
Owner

In revanced-patches-4.10.2, the Change version code patch has been changed to a universal patch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Suggestion Leave any other suggestions
Projects
None yet
Development

No branches or pull requests

4 participants