Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Sponsor block skipping not working properly in background mode #524

Closed
3 tasks done
rikinp93 opened this issue Mar 20, 2023 · 5 comments
Closed
3 tasks done
Labels
Bug report Something isn't working

Comments

@rikinp93
Copy link

Type

Error while patching

Application

YouTube v18.10.37

Bug description

Same as issue: ReVanced/revanced-patches#1761

Sponsorblock skipping when in background playback mode not working correctly. It doesn't skip in correct places on the videos, sometimes not even skipping.

When the app is open, not in background mode, skips are working correctly.

All sponsorblock settings are skip automatically.

Previous version 17.49.37 works fine.

Steps to reproduce

Steps included in the comments of ReVanced/revanced-patches#1761

Relevant log output

-

Screenshots or videos

No response

Solution

Solution for a fix created in ReVanced/revanced-patches#1761
ReVanced/revanced-patches#1765

Additional context

No response

Device Environment

Android 13 beta 3 pixel 7 pro

Acknowledgements

  • I have searched the existing issues and this is a new and no duplicate or related to another open issue.
  • I have written a short but informative title.
  • I filled out all of the requested information in this issue properly.
@rikinp93 rikinp93 added the Bug report Something isn't working label Mar 20, 2023
@rikinp93 rikinp93 changed the title bug: <title> bug: Sponsor block skipping not working properly in background mode Mar 20, 2023
@inotia00
Copy link
Owner

Unfortunately this issue is not reproducible

Unlike the official ReVanced, ReVanced Extended already has a PR for a fix reflected in it.

Also, sponsorblock segment submission is not skipped for other PlayerTypes including shorts.

@rikinp93
Copy link
Author

It is definitely happening for me on revanced extended as well. Weird

@rikinp93
Copy link
Author

Seems fixed now on revanced version ReVanced/revanced-patches#1765

This fixed it

@inotia00
Copy link
Owner

Can you test it on the latest Extended?

Because this commit is already applied to Extended..

@inotia00
Copy link
Owner

inotia00 commented Apr 2, 2023

fixed in revanced-patches-v2.168.1

@inotia00 inotia00 closed this as completed Apr 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug report Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants