Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ino-snackbar: add property for custom container id #1219

Open
4 tasks
janivo opened this issue Feb 1, 2024 · 1 comment
Open
4 tasks

ino-snackbar: add property for custom container id #1219

janivo opened this issue Feb 1, 2024 · 1 comment
Assignees

Comments

@janivo
Copy link
Collaborator

janivo commented Feb 1, 2024

Description

Currently, the ino-snackbar component is mounted to the document.body by default, which may not always be desirable, especially in scenarios where the application layout involves multiple containers. To address this limitation and provide more flexibility, a new property needs to be added to the ino-snackbar component to allow developers to specify a custom container ID where the snackbar should be mounted. This enhancement will enable use cases such as fullscreen modes where the snackbar should be appended to a specific container within the DOM.

Acceptance Criteria

  • A new property, such as customContainerId, is added to the ino-snackbar component.
  • The ino-snackbar component is updated to append to the specified custom container ID when provided.
  • Error handling is implemented to throw an error if the specified custom container ID is not found within the DOM.
  • The component's documentation is updated to include information about the new property and its usage.

Test Cases

  1. Custom Container ID Provided

    • Provide a custom container ID to the ino-snackbar component.
    • Verify that the snackbar is correctly appended to the specified custom container ID when rendered.
  2. Error Handling

    • Attempt to provide a non-existent custom container ID to the ino-snackbar component.
    • Confirm that an error is thrown, indicating that the specified custom container ID is not found.

Additional Information

We've implemented the same feature for the ino-tooltip and ino-popover. Have a look!

@janivo janivo added the new This issue has been recently added and has no estimation label Feb 1, 2024
@janivo janivo removed the new This issue has been recently added and has no estimation label Feb 22, 2024
@TobiasHeimGalindo TobiasHeimGalindo self-assigned this Mar 13, 2024
@janivo
Copy link
Collaborator Author

janivo commented Mar 14, 2024

postponed until #1319 is done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants