Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inline editing: onEditComplete is called even when editing is canceled #29

Closed
reactedlau opened this issue Jan 28, 2021 · 1 comment
Closed

Inline editing: onEditComplete is called even when editing is canceled #29

reactedlau opened this issue Jan 28, 2021 · 1 comment

Comments

@reactedlau
Copy link

  • what edition are you using - enterprise (for evaluation)
  • version - 4.0.20

Problem description:
The inline editing documentation here states that pressing the Escape key cancels cell editing. However, it seems that pressing Escape will call onEditCancel and onEditComplete, making it impossible to differentiate whether an edit was a true edit. I was able to reproduce this both on your documentation example and local code.

Expected behavior:
OnEditCancel and onEditComplete are mutually exclusive.
@inovua-admin
Copy link
Contributor

Fixed in 4.0.25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@reactedlau @inovua-admin