[Bug]: Infinite recursion with unhandled exception due to restore_exception_handler

[gaambo]

Description of the bug

I'm running into an infinite recursion when throwing an exception somehwere.
The PhpErrorController:on_exception exception handler is correctly called and logs the exception, but it then calls restore_exception_handler and re-throws the Exception which triggers the same function again.
According to a comment in the PHP docs:

Note that this does not work within an exception handler.

Therefore it runs the same method over and over again.

Reproduction instructions

1. Bootstrap the default configuration
2. Throw an exception somewhere in the code (e.g. on init)
3. See how the request times out because of maximul call stack size and the log is full of the same error message
4. alternative to 3: step-debug with xdebug and see the on_exception method get called over and over again

Expected behavior

In my case I just wanted to test the logging by manually throwing an exception. But when a real one throws, it loggs a huge amount of the same message and runs into fatal error with "Maximum call stack size".

I found out that you can use set_exception_handler(null); to reset it to the PHP defaults exception handler. Then the on_fatal will be called, because the exception is unhandled.

Another possibility would be to save the return-value of set_exception_handler (= the previous one) in Controller::log_php_errors and restore to it later.

Environment info

• Package version: v1.2.0
• Monolog: 1.27.1
• PHP: 8.3
• WordPress 6.5

Relevant log output

Fatal error: Uncaught Error: Maximum call stack size of 8339456 bytes (zend.max_allowed_stack_size - zend.reserved_stack_size) reached. Infinite recursion? in /var/www/html/vendor/inpsyde/wonolog/src/Data/Log.php:222 Stack trace: #0 /var/www/html/vendor/inpsyde/wonolog/src/Data/HookLogFactory.php(104): Inpsyde\Wonolog\Data\Log->level() #1 /var/www/html/vendor/inpsyde/wonolog/src/Data/HookLogFactory.php(88): Inpsyde\Wonolog\Data\HookLogFactory->maybe_raise_level(0, Object(Inpsyde\Wonolog\Data\Log)) #2 /var/www/html/vendor/inpsyde/wonolog/src/Data/HookLogFactory.php(38): Inpsyde\Wonolog\Data\HookLogFactory->extract_log_objects_in_args(Array, 0) #3 /var/www/html/vendor/inpsyde/wonolog/src/LogActionSubscriber.php(67): Inpsyde\Wonolog\Data\HookLogFactory->logs_from_hook_arguments(Array, 0) #4 /var/www/html/web/wp/wp-includes/class-wp-hook.php(324): Inpsyde\Wonolog\LogActionSubscriber->listen(Object(Inpsyde\Wonolog\Data\Log)) #5 /var/www/html/web/wp/wp-includes/class-wp-hook.php(348): WP_Hook->apply_filters('', Array) #6 /var/www/html/web/wp/wp-includes/plugin.php(517): WP_Hook->do_action(Array) #7 /var/www/html/vendor/inpsyde/wonolog/src/PhpErrorController.php(116): do_action('wonolog.log', Object(Inpsyde\Wonolog\Data\Log)) #8 [internal function]: Inpsyde\Wonolog\PhpErrorController->on_exception(Object(Exception)) #9 {main} thrown in /var/www/html/vendor/inpsyde/wonolog/src/Data/Log.php on line 222

Additional context

No response

Code of Conduct

• I agree to follow this project's Code of Conduct

[gaambo]

I've got a simple workaround running, by extending PhpErrorController: https://gist.github.com/gaambo/6ea135cdc28fe3b30e61c2713db78040

I still need to test this further, I'm just getting started with Wonolog.

But if this works and it's in your interest, I can draft up a PR.