Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple Backups on WP Multisites #64

Open
Christian-Roth opened this issue Apr 12, 2018 · 4 comments
Open

Multiple Backups on WP Multisites #64

Christian-Roth opened this issue Apr 12, 2018 · 4 comments
Assignees
Labels
Need tests Issue need better testing because it's old or not able to reproduce

Comments

@Christian-Roth
Copy link

Christian-Roth commented Apr 12, 2018

My WP Multisite creates multiple backups since the following change:

a4fb0a2#diff-29b55d7c830b04ca5f3b553cfcd9f78a

And as far as I can see it: is_main_network() is always true for every site of my multisite. And so the backup cron is executed by every subpage.

This should work:
if ( ! is_main_site() || ( ! is_main_network() && ! is_main_site() ) ) { return; }

Or:

if ( ! is_main_network() ) { return; }

if ( ! is_main_site() ) { return; }

@pavelevap
Copy link

I have the same problem, I will try to apply this fix, thank you very much @Christian-Roth!

When I run backup manually, there is only one backup archive, but when triggered by cron, then there are each backup archive for each site (only one of them is working and without problems).

@mundschenk-at
Copy link

There's at least one support ticket for this issue (from February 2018) with a proposed solution similar to the one above.

@cuongdcdev
Copy link
Contributor

cuongdcdev commented Aug 2, 2018

As I know, the latest ( 3.6 ) version fixed this issue

@Christian-Roth
Copy link
Author

Christian-Roth commented Aug 2, 2018

The issue got fixed at the wrong place :)
As mentioned here: https://wordpress.org/support/topic/multi-site-wpcron-multiple-backups/page/2/#post-10435815
And here: https://wordpress.org/support/topic/multi-site-wpcron-multiple-backups/page/3/#post-10436561

@widoz widoz added the Need tests Issue need better testing because it's old or not able to reproduce label Jan 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Need tests Issue need better testing because it's old or not able to reproduce
Projects
None yet
Development

No branches or pull requests

6 participants