Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update usage of the bip32ed25519 wrapper. #174

Merged
merged 2 commits into from
Jun 10, 2024
Merged

fix: update usage of the bip32ed25519 wrapper. #174

merged 2 commits into from
Jun 10, 2024

Conversation

elribonazo
Copy link
Contributor

@elribonazo elribonazo commented Jun 10, 2024 •
edited
Loading

Description:

Just upgrading the library to fix the package for all platforms

Checklist:

  • My PR follows the contribution guidelines of this project
  • My PR is free of third-party dependencies that don't comply with the Allowlist
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked the PR title to follow the conventional commit specification

@elribonazo
fix: update usage of the bip32ed25519 wrapper.
0dde122 
Signed-off-by: Francisco Javier Ribó Labrador <elribonazo@gmail.com>
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 10, 2024 •
edited
Loading

Code Coverage

File Coverage [63.83%] ❌
apollo/src/androidMain/kotlin/org/hyperledger/identus/apollo/derivation/EdHDKey.kt 63.83% ❌
apollo/src/appleMain/kotlin/org/hyperledger/identus/apollo/derivation/EdHDKey.kt 63.83% ❌
apollo/src/jsMain/kotlin/org/hyperledger/identus/apollo/derivation/EdHDKey.kt 63.83% ❌
apollo/src/jvmMain/kotlin/org/hyperledger/identus/apollo/derivation/EdHDKey.kt 63.83% ❌
Total Project Coverage 88.94% ❌

@elribonazo
fix: upgrade the bip32 wrapper commit to main
9f1d70e 
Signed-off-by: Francisco Javier Ribó Labrador <elribonazo@gmail.com>
@elribonazo elribonazo merged commit d1ee804 into main Jun 10, 2024
2 checks passed
@elribonazo elribonazo deleted the feature/ATL-7220 branch June 10, 2024 11:05
atala-dev added a commit that referenced this pull request Jun 10, 2024
@atala-dev
chore(release): cut apollo version 1.3.5
3b3e604 
## [1.3.5](v1.3.4...v1.3.5) (2024-06-10)

### Bug Fixes

* Removed references to Atala in docs and variables referred to by docs ([#172](#172)) ([ef2ae86](ef2ae86))
* update usage of the bip32ed25519 wrapper. ([#174](#174)) ([d1ee804](d1ee804))
@atala-dev
Copy link
Contributor

🎉 This PR is included in version 1.3.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

atala-dev added a commit that referenced this pull request Jun 10, 2024
@atala-dev
feat(docs): (3b3e604) chore(release): cut apollo version 1.3.5
010695a 
## [1.3.5](v1.3.4...v1.3.5) (2024-06-10)

### Bug Fixes

* Removed references to Atala in docs and variables referred to by docs ([#172](#172)) ([ef2ae86](ef2ae86))
* update usage of the bip32ed25519 wrapper. ([#174](#174)) ([d1ee804](d1ee804))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hamada147 hamada147 hamada147 approved these changes

@curtis-h curtis-h curtis-h approved these changes

@goncalo-frade-iohk goncalo-frade-iohk Awaiting requested review from goncalo-frade-iohk goncalo-frade-iohk is a code owner

@yshyn-iohk yshyn-iohk Awaiting requested review from yshyn-iohk yshyn-iohk is a code owner

@cristianIOHK cristianIOHK Awaiting requested review from cristianIOHK cristianIOHK is a code owner

@amagyar-iohk amagyar-iohk Awaiting requested review from amagyar-iohk amagyar-iohk is a code owner

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@elribonazo @atala-dev @hamada147 @curtis-h