Incorporate remaining ledger certificates #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jimbo4350
requested review from
dcoutts,
erikd,
newhoggy,
carbolymer and
disassembler
as code owners
Jimbo4350
force-pushed
the
jordan/incorporate-ledger-certificates
branch
3 times, most recently
from
7b65260
to
d44e00f
Compare
imports cardano-ledger's Cardano.Ledger.Api module and other necessary modules from cardano-ledger Introduce external module Cardano.Api.Ledger. This module reexports Cardano.Api.ReexposeLedger with the aim of transitioning cardano-api (and cardano-cli) to be fully reliant on cardano-ledger-api
ShelleyRelatedCertificate and ConwayCertificate. These wrap the data types exposed by cardano-ledger that correspond to the certificates of the aforementioned eras. Certificate era is also a GADT now.
resolve cardano-ledger's certificate related type families to the correct type given an era.
Jimbo4350
force-pushed
the
jordan/incorporate-ledger-certificates
branch
5 times, most recently
from
a9e6cd2
to
8303b8c
Compare
carbolymer
approved these changes
Jul 17, 2023
Jimbo4350
force-pushed
the
jordan/incorporate-ledger-certificates
branch
2 times, most recently
from
c220f39
to
e8fdfa0
Compare
different requirements of certificates across changing eras: StakeDelegationRequirements era StakePoolRegistrationRequirements era StakePoolRetirementRequirements era GenesisKeyDelegationRequirements era MirCertificateRequirements era DRepRegistrationRequirements era CommitteeHotKeyAuthorizationRequirements era CommitteeColdkeyResignationRequirements era DRepUnregistrationRequirements era In combination with the following GADTs: ConwayEraOnwards era and AtMostBabbageEra era. We inherit the type safety of the ledger's type families via the ConwayEraOnwards and AtMostBabbageEra GADTs.
Add helper functions selectStakeCredential and filterUnRegCreds
makeCommitteeColdkeyResignationCertificate makeCommitteeHotKeyAuthorizationCertificate makeDrepRegistrationCertificate makeDrepUnregistrationCertificate Re-export ledger types: MIRTarget MIRPot Import Cardano.Api.ReexposeLedger with the aim of consolidating all of the ledger modules cardano-api depends on. This will make it easier to hand off the cardano-api's ledger functionality to the ledger team.
Cardano.Api.Certificate
Jimbo4350
force-pushed
the
jordan/incorporate-ledger-certificates
branch
from
e8fdfa0
to
da9be77
Compare
newhoggy
added a commit
that referenced
this pull request
Mar 11, 2024
…CLI.Run.EraBased Move more era-based code to under `Cardano.CLI.EraBased` module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Context
Addititional context for the PR goes here.
If the PR fixes a particular issue please provide a
link
to the issue.
Checklist
.cabalfiles are updatedhlint. See.github/workflows/check-hlint.ymlto get thehlintversionstylish-haskell. See.github/workflows/stylish-haskell.ymlto get thestylish-haskellversionghc-8.10.7andghc-9.2.7Note on CI
If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.