Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conway drep registration: expose ledger anchor parameter #284

Merged
merged 1 commit into from
Oct 2, 2023

Conversation

smelc
Copy link
Contributor

@smelc smelc commented Sep 29, 2023

Note

I chose not to expose the ledger's StrictMaybe type, so I used Maybe instead as I felt this is what is done already. Let me know if I'm wrong.

Changelog

- description: |
    Expose Conway drep registration certificate anchor
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

This is required to attain a desired API in cardano-cli, see IntersectMBO/cardano-cli#198 (comment)

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • The change log section in the PR description has been filled in
  • NA New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • round trip tests
    • integration tests
      See Running tests for more details
  • NA The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • Self-reviewed the diff

@smelc smelc added this pull request to the merge queue Oct 2, 2023
Merged via the queue into main with commit e1e62e6 Oct 2, 2023
22 checks passed
@smelc smelc deleted the smelc/expose-dreg-registration-anchor branch October 2, 2023 12:09
smelc added a commit that referenced this pull request Oct 2, 2023
newhoggy added a commit that referenced this pull request Mar 11, 2024
Rename `SomeWitness` to `SomeSigningWitness`.  Rename constructors to avoid name conflicts.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants