Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protocol version change is not common to all versions anymore #358

Merged

Conversation

smelc
Copy link
Contributor

@smelc smelc commented Nov 6, 2023

Changelog

- description: |
    --protocol-(minor|major)-version cannot be changed via create-protocol-parameters-update command in conway
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

cardano-api part of fixing IntersectMBO/cardano-cli#388

How to trust this PR

  1. Observe that the cppProtocolVersion field is removed from the arguments common to all versions
  2. See it is moved to the new type DeprecatedAfterBabbagePParams
  3. Observe that the rest derives from there
  4. See PR on cardano-cli that uses this change: protocol-(major|minor)-version disappears in conway's create-protocol-parameters-update command cardano-cli#437

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@smelc smelc enabled auto-merge November 6, 2023 14:41
@smelc smelc added this pull request to the merge queue Nov 6, 2023
Merged via the queue into main with commit 914c7f3 Nov 6, 2023
21 checks passed
@smelc smelc deleted the smelc/conway-protocol-version-change-not-common-anymore branch November 6, 2023 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants