Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ByronTx #382

Merged
merged 11 commits into from Nov 28, 2023
Merged

Remove ByronTx #382

merged 11 commits into from Nov 28, 2023

Conversation

Jimbo4350
Copy link
Contributor

@Jimbo4350 Jimbo4350 commented Nov 21, 2023

Changelog

- description: |
    Remove `ByronTx` data constructor from `data Tx era`
    Delete Cardano.Api.Eon.ByronEraOnly module
    Remove `TxFeeImplicit` and `TxValidityNoUpperBound`
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Additional context for the PR goes here. If the PR fixes a particular issue please provide a link to the issue.

How to trust this PR

Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

}
} -> map (ByronTx ByronEraOnlyByron) txs
ByronBlock Consensus.ByronBlock{}-> error "getBlockTxs: Byron blocks currently not supported"
-- TODO: Determine if we care about Byron blocks. Likely not.
Copy link
Contributor Author

@Jimbo4350 Jimbo4350 Nov 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We actually do if QA intends to use foldBlocks with their hard forking tests. Not strictly true as foldBlocks can be called when we enter the Shelley era. It does not make sense to call foldBlocks in Byron because Byron does not have ledger events.

@Jimbo4350 Jimbo4350 force-pushed the jordan/remove-byron-tx branch 6 times, most recently from 2085ee9 to 427bb5e Compare November 27, 2023 19:12
@Jimbo4350 Jimbo4350 changed the title WIP: Remove ByronTx Remove ByronTx Nov 28, 2023
@Jimbo4350 Jimbo4350 force-pushed the jordan/remove-byron-tx branch 3 times, most recently from c171d24 to 8e2a9d3 Compare November 28, 2023 13:55
@Jimbo4350 Jimbo4350 marked this pull request as ready for review November 28, 2023 13:55
Copy link
Contributor

@carlhammann carlhammann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

cardano-api/gen/Test/Gen/Cardano/Api/Byron.hs Outdated Show resolved Hide resolved
cardano-api/internal/Cardano/Api/Eras/Case.hs Outdated Show resolved Hide resolved
@Jimbo4350 Jimbo4350 added this pull request to the merge queue Nov 28, 2023
Merged via the queue into main with commit 8561b74 Nov 28, 2023
20 checks passed
@Jimbo4350 Jimbo4350 deleted the jordan/remove-byron-tx branch November 28, 2023 18:46
newhoggy added a commit that referenced this pull request Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants