This repository has been archived by the owner on Feb 9, 2021. It is now read-only.
Make Lovelace and minfee concrete.
#210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
specs/ledger/latex/utxo.tex
Outdated
| % | ||
| \fun{b} & \PPMMap \to \mathbb{N} & \text{minumum fee constant}\\ | ||
| % | ||
| \fun{x} & \Tx \to \mathbb{N} & \text{minimum fee per-transaction} |
There was a problem hiding this comment.
This should probably be something more like "size", which would be described something like "the abstract size of a transaction", which we would be thinking of as something like number-of-bytes in a serialization. The name x might be a bit sparse and unclear.
There was a problem hiding this comment.
That makes sense. Thanks for the suggestion Jared. I'm changing it accordingly.
mgudemann
reviewed
Dec 11, 2018
specs/ledger/latex/utxo.tex
Outdated
| % | ||
| \fun{b} & \PPMMap \to \mathbb{N} & \text{minumum fee constant}\\ | ||
| % | ||
| \fun{x} & \Tx \to \mathbb{N} & \text{minimum fee per-transaction} |
There was a problem hiding this comment.
I just took the variable names that we used in the minimum fee calculation. I think @JaredCorduan has a better name for it though, so I'm changing it accordingly.
mgudemann
reviewed
Dec 11, 2018
There was a problem hiding this comment.
I think it's ok, but maybe we could add a specific function that "converts" nat to lovelace? Then minfee would become the calculation and application of that function. In reality, lovelace is bounded, so we cannot have a total minfee calculation. In a further refinement that could be added where appropriate.
dnadales
force-pushed
the
dnadales/lovelace-and-fees
branch
from
dbc671f
to
dc4c11a
Compare
JaredCorduan
approved these changes
Dec 11, 2018
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Dec 11, 2018
210: Make `Lovelace` and `minfee` concrete. r=dnadales a=dnadales
- Merge primitive types into abstract types.
- Add the set of natural numbers (`\mathbb{N}`) to the notation.
- Make Lovelace an alias for natural numbers.
- Replace `PrtclConsts` by `Ppms` (protocol-constants by protocol parameters),
to make it consistent with the update mechanism spec.
- Make function `minfee` concrete.
This closes #179, closes #75, and closes #54.
Co-authored-by: Damian Nadales <damian.nadales@iohk.io>
Timed out |
|
bors r+
|
iohk-bors bot
added a commit
that referenced
this pull request
Dec 11, 2018
210: Make `Lovelace` and `minfee` concrete. r=dnadales a=dnadales
- Merge primitive types into abstract types.
- Add the set of natural numbers (`\mathbb{N}`) to the notation.
- Make Lovelace an alias for natural numbers.
- Replace `PrtclConsts` by `Ppms` (protocol-constants by protocol parameters),
to make it consistent with the update mechanism spec.
- Make function `minfee` concrete.
This closes #179, closes #75, and closes #54.
Co-authored-by: Damian Nadales <damian.nadales@iohk.io>
Timed out |
- Merge primitive types into abstract types.
- Add the set of natural numbers (`\mathbb{N}`) to the notation.
- Make Lovelace an alias for natural numbers.
- Replace `PrtclConsts` by `Ppms` (protocol-constants by protocol parameters),
to make it consistent with the update mechanism spec.
- Make function `minfee` concrete.
- Make `balance` and `minfee` functions with range in the naturals.
- Add a constraint in the UTxO rule so that balances do not exceed the Lovelace cap.
- Make Lovelace a subset of the natural numbers.
dnadales
force-pushed
the
dnadales/lovelace-and-fees
branch
from
dc4c11a
to
8214ec1
Compare
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Dec 12, 2018
210: Make `Lovelace` and `minfee` concrete. r=dnadales a=dnadales
- Merge primitive types into abstract types.
- Add the set of natural numbers (`\mathbb{N}`) to the notation.
- Make Lovelace an alias for natural numbers.
- Replace `PrtclConsts` by `Ppms` (protocol-constants by protocol parameters),
to make it consistent with the update mechanism spec.
- Make function `minfee` concrete.
This closes #179, closes #75, and closes #54.
Co-authored-by: Damian Nadales <damian.nadales@iohk.io>
Build succeeded |
This was referenced Dec 13, 2018
Closed
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
\mathbb{N}) to the notation.PrtclConstsbyPpms(protocol-constants by protocol parameters),to make it consistent with the update mechanism spec.
minfeeconcrete.This closes #179, closes #75, and closes #54.