-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add options to delegate voting stake #109
Conversation
ec6e257
to
5ddf1d2
Compare
| --drep-verification-key STRING | ||
| --drep-verification-key-file FILE | ||
| --drep-key-hash HASH | ||
| ( --drep-verification-key STRING |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something's wrong with this parser - it's duplicated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is because one of the options allows you to delegate voting stake and reward stake in a single certificate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh I see it now. Makes sense I think, but it's a little confusing at the first glance. The duplicated help text also doesn't clarify that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's definitely confusing. We need to make this clearer to the user but we can do this after sanchonet.
623174d
to
643bbb0
Compare
c122471
to
d3a10cd
Compare
…n key and verification key file Add options to delegate voting stake to DReps and to simultaneously delegate voting stake and reward stake
d3a10cd
to
4e41272
Compare
Changelog
Context
Addititional context for the PR goes here.
If the PR fixes a particular issue please provide a
link
to the issue.
Checklist
See Runnings tests for more details
.cabal
files are updatedhlint
. See.github/workflows/check-hlint.yml
to get thehlint
versionstylish-haskell
. See.github/workflows/stylish-haskell.yml
to get thestylish-haskell
versionghc-8.10.7
andghc-9.2.7
Note on CI
If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.