Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove example era-based parsers we don't need anymore #180

Merged
merged 1 commit into from
Aug 18, 2023

Conversation

newhoggy
Copy link
Contributor

@newhoggy newhoggy commented Aug 17, 2023

Changelog

- description: |
    Remove example era-based parsers we don't need anymore
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

These commands were example era-sensitive commands only and are no longer needed

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • The change log section in the PR description has been filled in
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • round trip tests
    • integration tests
      See Running tests for more details
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • The changelog section in the PR is updated to describe the change
  • Self-reviewed the diff

@newhoggy newhoggy marked this pull request as ready for review August 17, 2023 13:38
@newhoggy newhoggy force-pushed the newhoggy/remove-example-era-based-parsers branch 2 times, most recently from 22e29ef to f14bb3c Compare August 17, 2023 14:34
@newhoggy newhoggy force-pushed the newhoggy/remove-example-era-based-parsers branch from f14bb3c to 75e2d3c Compare August 18, 2023 05:50
@newhoggy newhoggy added this pull request to the merge queue Aug 18, 2023
@newhoggy newhoggy removed this pull request from the merge queue due to a manual request Aug 18, 2023
@newhoggy newhoggy force-pushed the newhoggy/remove-example-era-based-parsers branch from 75e2d3c to c6ab9cb Compare August 18, 2023 06:05
@newhoggy newhoggy added this pull request to the merge queue Aug 18, 2023
Merged via the queue into main with commit 45d9b55 Aug 18, 2023
19 checks passed
@newhoggy newhoggy deleted the newhoggy/remove-example-era-based-parsers branch August 18, 2023 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants